Pouvez-vous m'aider à résoudre mon memory leak ?

Pouvez-vous m'aider à résoudre mon memory leak ? - C - Programmation

Marsh Posté le 21-04-2005 à 17:29:50    

Bonjour,
Voilà, je viens de faire un prog en C, et le problème, c'est que la mémoire qu'il utilise augmente sans arrêt. Alors j'ai lancé le programme avec valgrind, et voici ce qu'il me répond :

==13224== Memcheck, a memory error detector for x86-linux.
==13224== Copyright (C) 2002-2005, and GNU GPL'd, by Julian Seward et al.
==13224== Using valgrind-2.4.0, a program supervision framework for x86-linux.
==13224== Copyright (C) 2000-2005, and GNU GPL'd, by Julian Seward et al.
==13224== For more details, rerun with: -v
==13224==  
==13224==  
==13224== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 27 from 1)
==13224== malloc/free: in use at exit: 31465 bytes in 451 blocks.
==13224== malloc/free: 4120 allocs, 3669 frees, 3847254 bytes allocated.
==13224== For counts of detected errors, rerun with: -v
==13224== searching for pointers to 451 not-freed blocks.
==13224== checked 10924852 bytes.
==13224==  
==13224== 4 bytes in 1 blocks are still reachable in loss record 1 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x1B903EFB: realloc (vg_replace_malloc.c:188)
==13224==    by 0x80490E5: add (phpwrapperd.c:151)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 10 bytes in 2 blocks are still reachable in loss record 2 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x8049938: get_user (phpwrapperd.c:338)
==13224==    by 0x8049B77: send_phpconfig (phpwrapperd.c:379)
==13224==    by 0x804A08D: main (phpwrapperd.c:555)
==13224==  
==13224==  
==13224== 16 bytes in 1 blocks are still reachable in loss record 3 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x8048FFE: add (phpwrapperd.c:131)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 16 bytes in 1 blocks are still reachable in loss record 4 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x8049034: add (phpwrapperd.c:137)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 20 bytes in 2 blocks are still reachable in loss record 5 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x80499D9: get_user (phpwrapperd.c:346)
==13224==    by 0x8049B77: send_phpconfig (phpwrapperd.c:379)
==13224==    by 0x804A08D: main (phpwrapperd.c:555)
==13224==  
==13224==  
==13224== 20 bytes in 2 blocks are still reachable in loss record 6 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x8049077: add (phpwrapperd.c:142)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 28 bytes in 1 blocks are still reachable in loss record 7 of 19
==13224==    at 0x1B903F72: realloc (vg_replace_malloc.c:196)
==13224==    by 0x80490E5: add (phpwrapperd.c:151)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 48 bytes in 2 blocks are still reachable in loss record 8 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x8049825: get_user (phpwrapperd.c:315)
==13224==    by 0x8049B77: send_phpconfig (phpwrapperd.c:379)
==13224==    by 0x804A08D: main (phpwrapperd.c:555)
==13224==  
==13224==  
==13224== 60 bytes in 2 blocks are still reachable in loss record 9 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x8049A5C: get_user (phpwrapperd.c:351)
==13224==    by 0x8049B77: send_phpconfig (phpwrapperd.c:379)
==13224==    by 0x804A08D: main (phpwrapperd.c:555)
==13224==  
==13224==  
==13224== 68 bytes in 1 blocks are possibly lost in loss record 10 of 19
==13224==    at 0x1B903E89: calloc (vg_replace_malloc.c:175)
==13224==    by 0x1B8F2C2B: _dl_allocate_tls (in /lib/ld-2.3.2.so)
==13224==    by 0x1B9E126D: allocate_stack (in /lib/tls/libpthread-0.60.so)
==13224==    by 0x1B9E0EF7: pthread_create@@GLIBC_2.1 (in /lib/tls/libpthread-0.60.so)
==13224==    by 0x8049EB8: main (phpwrapperd.c:499)
==13224==  
==13224==  
==13224== 96 bytes in 14 blocks are still reachable in loss record 11 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x804A213: init_config (config.c:51)
==13224==    by 0x8049E3D: main (phpwrapperd.c:462)
==13224==  
==13224==  
==13224== 168 bytes in 14 blocks are still reachable in loss record 12 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x804A1C3: init_config (config.c:49)
==13224==    by 0x8049E3D: main (phpwrapperd.c:462)
==13224==  
==13224==  
==13224== 187 bytes in 8 blocks are still reachable in loss record 13 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x804913F: add (phpwrapperd.c:154)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 192 bytes in 14 blocks are still reachable in loss record 14 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x804A1EA: init_config (config.c:50)
==13224==    by 0x8049E3D: main (phpwrapperd.c:462)
==13224==  
==13224==  
==13224== 608 bytes in 76 blocks are indirectly lost in loss record 15 of 19
==13224==    at 0x1B903F72: realloc (vg_replace_malloc.c:196)
==13224==    by 0x80490E5: add (phpwrapperd.c:151)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 760 bytes in 76 blocks are indirectly lost in loss record 16 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x8049077: add (phpwrapperd.c:142)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 3420 bytes in 152 blocks are indirectly lost in loss record 17 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x804913F: add (phpwrapperd.c:154)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 6004 (1216 direct, 4788 indirect) bytes in 76 blocks are definitely lost in loss record 18 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x8048FFE: add (phpwrapperd.c:131)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224==  
==13224== 24528 bytes in 6 blocks are still reachable in loss record 19 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x1B923EA2: my_once_alloc (in /usr/lib/mysql/libmysqlclient.so.14.0.0)
==13224==    by 0x1B925244: init_state_maps (in /usr/lib/mysql/libmysqlclient.so.14.0.0)
==13224==    by 0x1B92510C: get_charset_by_csname (in /usr/lib/mysql/libmysqlclient.so.14.0.0)
==13224==    by 0x1B93564E: mysql_real_connect (in /usr/lib/mysql/libmysqlclient.so.14.0.0)
==13224==    by 0x8049262: reset_configs (phpwrapperd.c:172)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==13224==  
==13224== LEAK SUMMARY:
==13224==    definitely lost: 1216 bytes in 76 blocks.
==13224==    indirectly lost: 4788 bytes in 304 blocks.
==13224==      possibly lost: 68 bytes in 1 blocks.
==13224==    still reachable: 25393 bytes in 70 blocks.
==13224==         suppressed: 0 bytes in 0 blocks.


Il me dit bien qu'il y a des pertes de mémoire. Mais par où dois-je commencer pour résoudre ces erreurs ?
Merci
 :hello:

Reply

Marsh Posté le 21-04-2005 à 17:29:50   

Reply

Marsh Posté le 21-04-2005 à 19:21:19    


Sans le code, on peut pas t'aider.
 


---------------
Des infos sur la programmation et le langage C: http://www.bien-programmer.fr Pas de Wi-Fi à la maison : http://www.cpl-france.org/
Reply

Marsh Posté le 21-04-2005 à 19:35:45    

oué, mais bon il t'indique les fonctions causant des fuites et le lieu de l'allocation, avec ca tu devrais y arriver


---------------
NP: HTTP Error 764 Stupid coder found
Reply

Marsh Posté le 22-04-2005 à 09:40:46    

Puisque c'est si gentillement demandé :)
Voici les parties du code qui pourraient poser problème :
 

Code :
  1. typedef struct _configs {
  2.   char* nom;
  3.   int n;
  4.   char** params;
  5.   struct _configs* next;
  6. } configs;
  8. typedef struct _users {
  9.   char* nom;
  10.   char* type;
  11.   char* open_basedir;
  12.   struct _users* last;
  13.   struct _users* next;
  14.   time_t timestamp;
  15. } users;
  17. configs* c;
  18. users* user;
  19. int n_users;
  21. void add(char* type, char* name, char* value) {
  22.   configs* d=c;
  23.   configs* e=NULL;
  25.   while (d!=NULL) {
  26.     if(d->nom==NULL || type==NULL)
  27.       return;
  28.     if(strcmp(d->nom,type)==0)
  29.       break;
  30.     e=d;
  31.     d=d->next;
  32.   }
  34.   if(d==NULL) {
  35.     if(e!=NULL) {
  36.       e->next=(configs*)malloc(sizeof(configs)); // Ligne 131
  37.       if(e->next==NULL)
  38. syslog(LOG_NOTICE,"Erreur d'allocation (121)" );
  39.       d=e->next;
  40.     }
  41.     else {
  42.       c=(configs*)malloc(sizeof(configs)); // Ligne 137
  43.       if(c==NULL)
  44. syslog(LOG_NOTICE,"Erreur d'allocation (127)" );
  45.       d=c;
  46.     }
  47.     d->nom=(char*)malloc((strlen(type)+1)*sizeof(char));
  48.     if(d->nom==NULL)
  49.       syslog(LOG_NOTICE,"Erreur d'allocation (132)" );
  50.     strcpy(d->nom,type);
  51.     d->n=0;
  52.     d->params=NULL;
  53.   }
  55.   d->n+=1;
  56.   d->params=(char**)realloc(d->params,d->n*sizeof(char*)); // Ligne 151
  57.   if(d->params==NULL)
  58.     syslog(LOG_NOTICE,"Erreur d'allocation (141)" );
  59.   d->params[d->n-1]=(char*)malloc((strlen(name)+strlen(value)+3)*sizeof(char));
  60.   if(d->params[d->n-1]==NULL)
  61.     syslog(LOG_NOTICE,"Erreur d'allocation (144)" );
  62.   d->next=NULL;
  63.   sprintf(d->params[d->n-1],"%s=%s\n",name,value);
  64. }
  66. void freeconfigs() {
  67.   int i;
  68.   configs *n,*d=c;
  70.   while(d!=NULL) {
  71.     n=d->next;
  73.     free(d->nom);
  74.     for(i=0;i<d->n;i++) {
  75.       free(d->params[i]);
  76.     }
  77.     if(d->params!=NULL) {
  78.       free(d->params);
  79.     }
  80.     free(d);
  81.     d=n;
  82.   }
  83.   c=NULL;
  84. }
  86. void reset_configs() {
  87.   MYSQL m;
  88.   int i, err;
  89.   MYSQL_RES *r1;
  90.   MYSQL_ROW row;
  92.   mysql_init(&m);
  93.   mysql_options(&m,MYSQL_READ_DEFAULT_GROUP,"phpwrapperd" );
  95.   for(i=0;i<getValueI("MYSQL_RETRY" );i++) {
  96.     if(!mysql_real_connect(&m,
  97.      getValueS("MYSQL_HOST" ),
  98.      getValueS("MYSQL_LOGIN" ),
  99.      getValueS("MYSQL_PASSWORD" ),
  100.      getValueS("MYSQL_DB" ),
  101.      0,
  102.      getValueS("MYSQL_SOCK" ),
  103.      0)) {
  104.       syslog(LOG_NOTICE, "Impossible de se connecter au server mysql : %s\n",mysql_error(&m));
  105.       if(i==getValueI("MYSQL_RETRY" )-1) {
  106. syslog(LOG_NOTICE,"!!! Abandon de connexion au serveur MySQL !!!" );
  107. return;
  108.       }
  109.     }
  110.     else
  111.       i=getValueI("MYSQL_RETRY" );
  112.   }
  113.  
  114.   mysql_query(&m,"select * from php_config" );
  115.   r1=mysql_store_result(&m);
  116.   if(r1==NULL) {
  117.     syslog(LOG_NOTICE,"`select * from php_config' : %s\n",mysql_error(&m));
  118.     mysql_close(&m);
  119.     return;
  120.   }
  122.   freeconfigs();
  124.   while ((row = mysql_fetch_row(r1))) {
  125.     mysql_commit(&m);
  126.     add(row[0],row[1],row[2]); // Ligne 203
  127.   }
  129.   mysql_free_result(r1);
  130.   mysql_close(&m);
  131. }
  133. void get_user(char* name, char** base_dir, char** type) {
  134.   MYSQL m;
  135.   int i, err;
  136.   char* query;
  137.   MYSQL_RES *r1;
  138.   MYSQL_ROW row;
  139.   users* u;
  140.   users* tmp;
  141.   int exists=1;
  143.   u=user;
  144.   if(user==NULL)
  145.     exists=0;
  146.   else {
  147.     if(user->nom==NULL || name==NULL)
  148.       return;
  149.     while(strcmp(u->nom,name)) {
  150.       u=u->next;
  151.       if(u==user) {
  152. exists=0;
  153. break;
  154.       }
  155.     }
  156.   }
  158.   if(!exists || u->timestamp<(time(NULL)-getValueI("REFRESH_CACHE_USERS_DELAY" ))) {
  160.     query=(char*)malloc((49+strlen(name))*sizeof(char));
  161.     if(query==NULL)
  162.       syslog(LOG_NOTICE,"Erreur d'allocation (272)" );
  163.     sprintf(query,"select type,homedir from users where username='%s'",name);
  164.    
  165.     mysql_init(&m);
  166.     mysql_options(&m,MYSQL_READ_DEFAULT_GROUP,"phpwrapperd" );
  167.    
  168.     for(i=0;i<getValueI("MYSQL_RETRY" );i++) {
  169.       if(!mysql_real_connect(&m,
  170.        getValueS("MYSQL_HOST" ),
  171.        getValueS("MYSQL_LOGIN" ),
  172.        getValueS("MYSQL_PASSWORD" ),
  173.        getValueS("MYSQL_DB" ),
  174.        0,
  175.        getValueS("MYSQL_SOCK" ),
  176.        0)) {
  177. syslog(LOG_NOTICE,"Impossible de se connecter au server mysql : %s\n",mysql_error(&m));
  178. if(i==getValueI("MYSQL_RETRY" )-1) {
  179.   syslog(LOG_NOTICE,"!!! Abandon de connexion au serveur MySQL !!!" );
  180.   free(query);
  181.   return;
  182. }
  183.       }
  184.       else
  185. break;
  186.     }
  187.    
  188.     mysql_query(&m,query);
  189.     r1=mysql_store_result(&m);
  190.     if(mysql_num_rows(r1)==0 || r1==NULL){
  191.       if(r1==NULL)
  192. syslog(LOG_NOTICE,"`%s' : %s\n",query, mysql_error(&m));
  193.       *base_dir=NULL;
  194.       *type=NULL;
  195.       mysql_free_result(r1);
  196.       mysql_close(&m);
  197.       free(query);
  198.       return;
  199.     }
  201.     if(!exists)
  202.       syslog(LOG_NOTICE,"Adding user `%s' in cache", name); 
  203.     else
  204.       syslog(LOG_NOTICE,"Updating user `%s' in cache", name); 
  205.    
  206.     if(n_users>=getValueI("MAX_USERS_CACHE" ))
  207.       free_last_user();
  208.    
  209.     u=(users*)malloc(sizeof(users));
  210.     if(u==NULL)
  211.       syslog(LOG_NOTICE,"Erreur d'allocation (302)" );
  213.     if(user==NULL) {
  214.       u->last=u;
  215.       u->next=u;
  216.       n_users=1;
  217.     }
  218.     else {
  219.       tmp=user->last;
  220.       u->last=tmp;
  221.       u->next=user;
  222.       user->last=u;
  223.       u->last->next=u;
  224.       n_users++;
  225.     }
  226.     u->nom=NULL;
  227.     u->type=NULL;
  228.     u->open_basedir=NULL;
  229.     user=u;
  231.     if(u->nom!=NULL) free(u->nom);
  232.     u->nom=(char*)malloc((strlen(name)+1)*sizeof(char)); // Ligne 338
  233.     if(u->nom==NULL)
  234.       syslog(LOG_NOTICE,"Erreur d'allocation (344)" );
  235.     strcpy(u->nom,name);
  236.    
  237.     row = mysql_fetch_row(r1);
  238.     mysql_commit(&m);
  239.     if(u->type!=NULL) free(u->type);
  240.     u->type=(char*)malloc((strlen(row[0])+1)*sizeof(char));  // Ligne 346
  241.     if(u->type==NULL)
  242.       syslog(LOG_NOTICE,"Erreur d'allocation (352)" );
  243.     strcpy(u->type,row[0]);
  244.     if(u->open_basedir!=NULL) free(u->open_basedir);
  245.     u->open_basedir=(char*)malloc((strlen(row[1])+1)*sizeof(char));
  246.     if(u->open_basedir==NULL)
  247.       syslog(LOG_NOTICE,"Erreur d'allocation (357)" );
  248.     strcpy(u->open_basedir,row[1]);
  249.     mysql_free_result(r1);
  250.     mysql_close(&m);
  251.     free(query);
  252.    
  253.     u->timestamp=time(NULL);
  254.     exists=1;
  255.   }
  256.   else {
  257.     *base_dir=u->open_basedir;
  258.     *type=u->type;
  259.   }
  260. }
  262. void send_phpconfig() {
  263.   configs* d=c;
  264.   char line[MAXLINE];
  265.   char *openbase_dir=NULL;
  266.   char *type=NULL;
  267.   int i;
  269.   readline(newsockfd,line,MAXLINE);
  271.   get_user(line,&openbase_dir,&type); // Ligne 379
  272.   if (openbase_dir==NULL || type==NULL) {
  273.     syslog(LOG_NOTICE,"unknown user `%s'",line);
  274.     return;
  275.   }
  277.   d=c;
  279.   if(d!=NULL) {
  280.     if(d->nom==NULL || type==NULL)
  281.       return;
  282.     while(strcmp(d->nom,type))
  283.       d=d->next;
  284.     for(i=0;i<d->n;i++){
  285.       writen(newsockfd,d->params[i],strlen(d->params[i]));
  286.     }
  287.   }
  288.   sprintf(line,"open_basedir=%s\n",openbase_dir);
  290.   writen(newsockfd,line,strlen(line)+1);
  292.   writen(newsockfd,"\n",1);
  293. }


 
EDIT : ajout des n° de ligne utiles


Message édité par Profil supprimé le 22-04-2005 à 09:51:27
Reply

Marsh Posté le 22-04-2005 à 10:58:58    

ha! sauf que tes numéros de lignes ne correspondent pas aux numéros de lignes de valgrind...
Par exemple:
==13224== 4 bytes in 1 blocks are still reachable in loss record 1 of 19
==13224==    at 0x1B90354C: malloc (vg_replace_malloc.c:130)
==13224==    by 0x1B903EFB: realloc vg_replace_malloc.c:188)
==13224==    by 0x80490E5: add (phpwrapperd.c:151)
==13224==    by 0x80493B4: reset_configs (phpwrapperd.c:203)
==13224==    by 0x804A047: main (phpwrapperd.c:537)
==
 
C'est-à-dire que tu fais un alloc sans free à la ligne 151 du fichier phpwrapperd.c, dans la fonction add

Reply

Marsh Posté le 22-04-2005 à 11:44:05    

J'ai mis les n° de lignes en commentaires aux endroits indiqués par valgrind ;)

Reply

Sujets relatifs:

Leave a Replay

Make sure you enter the(*)required information where indicate.HTML code is not allowed